From 3ae6f8fec1381df41dc05272bfe3ab03654ac4af Mon Sep 17 00:00:00 2001 From: Yen Chi Hsuan Date: Thu, 31 Mar 2016 02:11:21 +0800 Subject: [PATCH] [kwuo] Remove _sort_formats() from KuwoBaseIE._get_formats() Following the idea proposed in 19dbaeece321c51fa336ef142507adf440e22e22 --- youtube_dl/extractor/kuwo.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/youtube_dl/extractor/kuwo.py b/youtube_dl/extractor/kuwo.py index 84c0f363d..f09436332 100644 --- a/youtube_dl/extractor/kuwo.py +++ b/youtube_dl/extractor/kuwo.py @@ -44,11 +44,6 @@ def _get_formats(self, song_id, tolerate_ip_deny=False): 'abr': file_format.get('abr'), }) - # XXX _sort_formats fails if there are not formats, while it's not the - # desired behavior if 'IPDeny' is ignored - # This check can be removed if https://github.com/rg3/youtube-dl/pull/8051 is merged - if not tolerate_ip_deny: - self._sort_formats(formats) return formats @@ -103,6 +98,7 @@ def _real_extract(self, url): lrc_content = None formats = self._get_formats(song_id) + self._sort_formats(formats) album_id = self._html_search_regex( r']+class="album"[^<]+]+href="http://www\.kuwo\.cn/album/(\d+)/"',