mirrors/yt-dlp
1
1
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-11-22 08:21:40 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[ie/archive.org] Fix comments extraction (#11527)
Some checks failed
CodeQL / Analyze (python) (push) Has been cancelled
Details
Download Tests / Quick Download Tests (push) Has been cancelled
Details
Download Tests / Full Download Tests (ubuntu-latest, 3.10) (push) Has been cancelled
Details
Download Tests / Full Download Tests (ubuntu-latest, 3.11) (push) Has been cancelled
Details
Download Tests / Full Download Tests (ubuntu-latest, 3.12) (push) Has been cancelled
Details
Download Tests / Full Download Tests (ubuntu-latest, 3.13) (push) Has been cancelled
Details
Download Tests / Full Download Tests (ubuntu-latest, pypy-3.10) (push) Has been cancelled
Details
Download Tests / Full Download Tests (windows-latest, 3.9) (push) Has been cancelled
Details
Download Tests / Full Download Tests (windows-latest, pypy-3.10) (push) Has been cancelled
Details
Quick Test / Core Test (push) Has been cancelled
Details
Quick Test / Code check (push) Has been cancelled
Details
Release (master) / release (push) Has been cancelled
Details
Release (master) / publish_pypi (push) Has been cancelled
Details

Browse Source 
Closes #11526
Authored by: jshumphrey
This commit is contained in:
Jackson Humphrey 2024-11-12 17:26:18 -06:00 committed by GitHub
parent bacc31b05a
commit f2a4983df7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
yt_dlp/extractor/archiveorg.py
View File

@ -205,6 +205,26 @@ class ArchiveOrgIE(InfoExtractor):
},
},
],
}, {
# The reviewbody is None for one of the reviews; just need to extract data without crashing
'url': 'https://archive.org/details/gd95-04-02.sbd.11622.sbeok.shnf/gd95-04-02d1t04.shn',
'info_dict': {
'id': 'gd95-04-02.sbd.11622.sbeok.shnf/gd95-04-02d1t04.shn',
'ext': 'mp3',
'title': 'Stuck Inside of Mobile with the Memphis Blues Again',
'creators': ['Grateful Dead'],
'duration': 338.31,
'track': 'Stuck Inside of Mobile with the Memphis Blues Again',
'description': 'md5:764348a470b986f1217ffd38d6ac7b72',
'display_id': 'gd95-04-02d1t04.shn',
'location': 'Pyramid Arena',
'uploader': 'jon@archive.org',
'album': '1995-04-02 - Pyramid Arena',
'upload_date': '20040519',
'track_number': 4,
'release_date': '19950402',
'timestamp': 1084927901,
},
}]
@staticmethod
@ -335,7 +355,7 @@ def _real_extract(self, url):
info['comments'].append({
'id': review.get('review_id'),
'author': review.get('reviewer'),
'text': str_or_none(review.get('reviewtitle'), '') + '\n\n' + review.get('reviewbody'),
'text': join_nonempty('reviewtitle', 'reviewbody', from_dict=review, delim='\n\n'),
'timestamp': unified_timestamp(review.get('createdate')),
'parent': 'root'})